Base CMakeLists.txt cleanup, reduced tarball testing, CI enable tweak, TriBITS update (#11545, #11976) #12044

bartlettroscoe · 2023-07-12T20:26:02Z

Addresses:

Build and install downstream Trilinos packages against pre-installed Kokkos using native CMake build system #11545
Tribits: make package_source creates tarballs with missing BuildStatsWrappers.cmake #11976

Description

This PR branch does some cleanup, addresses a few issues, and updates the TriBITS snapshot in Trilinos. In more detail:

Added automated test for reduced tarball creation (NOTE: Currently this will not run in any of the automated Trilinos builds due to the issue described in c84bb27.)
The logic for how the Trilinos installation-related tests are enabled is changed as described in commit cb4090d
An updated TriBITS snapshot is brought in
The base Trilinos CMakeLists.txt file is cleaned up by moving the details to several individual *.cmake files
Remove unneeded calls to removed macro tribits_exclude_autotools_files()
Revert commits from PR #11977 and replace with commit that keeps commonTools/build_stats in reduced tarball
Make a few small changes needed to get reduced tarball to work (i.e. Tpetra)
Finish cleanup of the removal of Kokkos subpackages (Build and install downstream Trilinos packages against pre-installed Kokkos using native CMake build system #11545, Remove usage of subpackages from TriBITS Kokkos build and downstream Trilinos packages (#11545) #11808)

Instructions for reviewers

Please review the commits individually
Please don't review the TriBITS updates too much here but instead refer back to the TriBITS PRs these originate from

Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' Git describe: vera-release-3.5-start-1802-g6d9eaef0 At commit: commit 24e96fe74bfca6c42b8aedb96468ee4ed22a8062 Author: Roscoe A. Bartlett <[email protected]> Date: Tue Jun 27 08:14:20 2023 -0600 Summary: Print out <Package>_DIR and error out if not set (#63)

Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' Git describe: vera-release-3.5-start-1806-ge88b8af8 At commit: commit 1a9b519a5cd6005d299be5d07c8823a6a87c974e Author: Roscoe A. Bartlett <[email protected]> Date: Tue Jun 27 17:28:15 2023 -0600 Summary: Only submit warning for existing ignored package dir in WARNING mode (#11976)

This reverts commit 40e37d9. There is a better fix in TriBITS 'master' that will be merged in from the snapshot branch. I needed to revert this or it would be a conflict.

This reverts commit 7c630d7. I am going to remove the exclude entry instead and put in excludes for the wrapper TriBITS package CMakeLists.txt and cmake/Dependencies.cmake files instead so that it will not show up as a TriBITS package.

This allows the TrilinosBuildStats test package to be removed but still keep the build_stats files to provide that functionality to tarball customers.

Cleaning up the base CMakeLists.txt file some

Cleaning up the base CMakeLists.txt file.

We removed autotools files from the Trilinos tarball 14 years ago because those we kept those around but they were out of date and we did not want customers using them. But since they have been stripped out of every Trilinos package (except Zoltan), there is no value in including this. Also, the latest TriBITS snapshot removed this macro. The only package that still has old autotools files in Zoltan. These have been stripped out of every other Trilinos package. For Zolan, we now leave the autotools files in the tarball. However, I did not remove the usage TRIBITS_EXCLUDE_AUTOTOOLS_FILES() from Kokkos or KokkosKernels so I could avoid the proces of having to get these changes into the latest Kokkos 4.1 release. I will post PRs to pull out the usage of TRIBITS_EXCLUDE_AUTOTOOLS_FILES() from the 'develop' branches of the native repos so this can be cleaned up later. For now, I will create an empty macro TRIBITS_EXCLUDE_AUTOTOOLS_FILES() to allow these packages to be unchanged.

…TriBITS#299) Support for Makefile.export.* files was removed from TriBITS and snaphsotted into Trilinos a long time ago. This support was removed in the Trilinos 14.0 release. There is no reason to keep this cache variable anymore. It just clutters up the base CMakeLists.txt file.

Cleaning up the base CMakeLists.txt file

Put misc hacks and stuff in there to clean up the base Trilinos/CMakeLists.txt file.

Noticed this while cleaning up from the removal of Kokkos subpackages (See PR

…#11808) This duplication resulted from running a simple automated script that created a commit in PR #11808.

…ribits-update This pulls in the new TriBITS PRs: * TriBITSPub/TriBITS#583 * TriBITSPub/TriBITS#585 * TriBITSPub/TriBITS#586 * TriBITSPub/TriBITS#587 * TriBITSPub/TriBITS#588 * TriBITSPub/TriBITS#590

It appears that no Tpetra tests even use this file so why is it being copied from Anasazi_SOURCE_DIR? Well, when you create a reduced tarball with Tpetra and without Anasazi, the packages/anasazi directory does not even exist and the varaible Anasazi_SOURCE_DIR does not exist.

…12024) This sets up a test that would have caught the problem in #11976 and will provide some protection for reduced tarball creation going forward. NOTE: Currently, this test will only be added if configure settings are passed through `-D${CMAKE_PROJECT_NAME}_CONFIGURE_OPTIONS_FILE=<cache-file>.cmake`. There is no way to pass that file (or thoses files) through `-C <cache-file>.make`.

* Now TrilinosInstallTests will be enabled if any Trilinos package gets enabled. * Removed dependence of TrilinosInstallTests on Tpetra. This should give more consistent installation testing with Trilinos. Prior to this commit, only changes to Tpetra and packages upstream from Tpetra would trigger the enable of the TrilinosInstallTests package and the running of these tests. Now, any change to any Trilinos packge will trigger some installation testing. See new TrilinosInstallTests/READMME.md file for details.

trilinos-autotester · 2023-07-12T20:43:28Z

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

trilinos-autotester · 2023-07-12T20:46:05Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2493
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1021
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1013
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1012
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2234
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2014
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 652
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2023-07-13T03:28:09Z

NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester...

trilinos-autotester · 2023-07-13T03:30:41Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2496
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1024
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1016
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1015
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2237
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2017
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 655
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)

Pull Request Author: bartlettroscoe

trilinos-autotester · 2023-07-13T07:13:45Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Build Num: 2496
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Build Num: 1024
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Build Num: 1016
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Build Num: 1015
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_python3

Build Num: 2237
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	ascic
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Build Num: 2017
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	GPU
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

Build Information

Test Name: Trilinos_PR_intel-2021.3

Build Num: 655
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	TriBITS;PA: Framework
PULLREQUESTNUM	12044
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	trilinos-any
TRILINOS_SOURCE_BRANCH	11545-11976-cleanup-and-tribits-update
TRILINOS_SOURCE_REPO	https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA	`cb4090d`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`ab6f880`

CDash Test Results for PR# 12044.

trilinos-autotester · 2023-07-13T07:14:02Z

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

trilinos-autotester · 2023-07-13T07:14:12Z

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

sebrowne

I will admit to not going through this in excruciating detail, but what I saw matches the description of the change, and all of that sounds fine to me.

trilinos-autotester · 2023-07-13T16:45:21Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ sebrowne ]!

trilinos-autotester · 2023-07-13T16:45:29Z

Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR...

bartlettroscoe added 19 commits June 27, 2023 11:10

Revert "TriBITS: Temp fix for configuring from reduced tarball (#11976)"

d0d10e8

This reverts commit 40e37d9. There is a better fix in TriBITS 'master' that will be merged in from the snapshot branch. I needed to revert this or it would be a conflict.

Keep commonTools/build_stats but strip TriBITS package stuff (#11976)

f2e3512

This allows the TrilinosBuildStats test package to be removed but still keep the build_stats files to provide that functionality to tarball customers.

Move logic for CCache setup to module file

160fbdd

Cleaning up the base CMakeLists.txt file some

Move TriBITS install logic to its own module

c645e06

Cleaning up the base CMakeLists.txt file.

Move C++ standard selection logic to a module file

ed260e2

Cleaning up the base CMakeLists.txt file

Break out a TrilinosTweaks.cmake file

c001ff6

Put misc hacks and stuff in there to clean up the base Trilinos/CMakeLists.txt file.

Moertel: Remove unnecessary include dirs (#11545, #11808)

a624fec

Noticed this while cleaning up from the removal of Kokkos subpackages (See PR

Tpetra: Remove duplication from removal of Kokkos subpackages (#11545, …

dedfd47

…#11808) This duplication resulted from running a simple automated script that created a commit in PR #11808.

Sacado: Remove duplication from removal of Kokkos subpackages (#11545, …

fd4817a

…#11808) This duplication resulted from running a simple automated script that created a commit in PR #11808.

Merge branch 'tribits_github_snapshot' into 11545-11976-cleanup-and-t…

e61bf3e

…ribits-update This pulls in the new TriBITS PRs: * TriBITSPub/TriBITS#583 * TriBITSPub/TriBITS#585 * TriBITSPub/TriBITS#586 * TriBITSPub/TriBITS#587 * TriBITSPub/TriBITS#588 * TriBITSPub/TriBITS#590

Remove some left-over debugging print statements (#11976)

2d1361a

bartlettroscoe added TriBITS Issues with the TriBITS framework itself, not usage of the TriBITS framework PA: Framework Issues that fall under the Trilinos Framework Product Area labels Jul 12, 2023

bartlettroscoe requested a review from sebrowne July 13, 2023 00:30

bartlettroscoe changed the title ~~11545 11976 cleanup and tribits update~~ Base CMakeLists.txt cleanup, reduced tarball testing, CI enable tweak, TriBITS update (#11545, #11976) Jul 13, 2023

sebrowne approved these changes Jul 13, 2023

View reviewed changes

bartlettroscoe mentioned this pull request Jul 7, 2023

Test and support creation of reduced Trilinos tarballs #12024

Open

4 tasks

bartlettroscoe merged commit 6c1b360 into develop Jul 13, 2023

This was referenced Jul 14, 2023

Build and install downstream Trilinos packages against pre-installed Kokkos using native CMake build system #11545

Closed

Kokkos/TriBITs: cmake complaining about unknown command TRIBITS_EXCLUDE_AUTOTOOLS_FILES #12057

Closed

ccober6 deleted the 11545-11976-cleanup-and-tribits-update branch March 6, 2024 16:59

Base CMakeLists.txt cleanup, reduced tarball testing, CI enable tweak, TriBITS update (#11545, #11976) #12044

Base CMakeLists.txt cleanup, reduced tarball testing, CI enable tweak, TriBITS update (#11545, #11976) #12044

Conversation

bartlettroscoe commented Jul 12, 2023 • edited Loading

Description

Instructions for reviewers

trilinos-autotester commented Jul 12, 2023

trilinos-autotester commented Jul 12, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Jul 13, 2023

trilinos-autotester commented Jul 13, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

Using Repos:

trilinos-autotester commented Jul 13, 2023

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_clang-11.0.1

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_python3

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

Jenkins Parameters

Build Information

Test Name: Trilinos_PR_intel-2021.3

Jenkins Parameters

trilinos-autotester commented Jul 13, 2023

trilinos-autotester commented Jul 13, 2023

sebrowne left a comment

Choose a reason for hiding this comment

bartlettroscoe commented Jul 12, 2023 •

edited

Loading