Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependency libraries and etc / Improve pom.xml #329

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Clean up dependency libraries and etc / Improve pom.xml #329

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
94c05e3
Remove an unused dependency library
yuokada Jun 28, 2024
00abea8
Update test dependency libraries
yuokada Jun 28, 2024
af26344
Downgrade littleproxy to 2.0.15
yuokada Jun 28, 2024
cdc799d
Replace additionalparam with additionalOptions
yuokada Jun 28, 2024
587fe5a
Upgrade checkstyle to v9 (#330)
yuokada Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 14 additions & 20 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,23 +161,17 @@
<dependency>
<groupId>org.immutables</groupId>
<artifactId>value</artifactId>
<version>2.2.10</version>
<version>2.10.1</version>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>org.immutables</groupId>
<artifactId>builder</artifactId>
<version>2.2.10</version>
<version>2.10.1</version>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the result when the command executes at the master branch.

~/I/td-client-java ❯❯❯ mvn dependency:analyze-only
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------< com.treasuredata.client:td-client >------------------
[INFO] Building Treasure Data Client for Java 1.1.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:3.6.1:analyze-only (default-cli) @ td-client ---
[WARNING] Used undeclared dependencies found:
[WARNING]    com.google.code.findbugs:jsr305:jar:3.0.2:compile
[WARNING]    com.squareup.okio:okio:jar:1.17.2:compile
[WARNING]    org.hamcrest:hamcrest:jar:2.2:test
[WARNING]    io.netty:netty-codec-http:jar:4.1.86.Final:test
[WARNING]    io.netty:netty-transport:jar:4.1.86.Final:test
[WARNING] Unused declared dependencies found:
[WARNING]    javax.annotation:javax.annotation-api:jar:1.3.2:compile
[WARNING] Non-test scoped test only dependencies found:
[WARNING]    com.squareup.okio:okio:jar:1.17.2:compile
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.948 s
[INFO] Finished at: 2024-06-28T12:50:06+09:00
[INFO] ------------------------------------------------------------------------

<version>1.3.2</version>
</dependency>

<!-- ==================== -->
<!-- Testing dependencies -->
<!-- ==================== -->
Expand All @@ -202,14 +196,14 @@
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>5.10.0</version>
<version>5.12.0</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.bigtesting</groupId>
<artifactId>fixd</artifactId>
<version>1.0.0</version>
<version>1.0.5</version>
<scope>test</scope>
<exclusions>
<exclusion>
Expand Down Expand Up @@ -433,7 +427,7 @@
<source>${project.build.targetJdk}</source>
<encoding>${project.build.sourceEncoding}</encoding>
<maxmemory>${project.build.jvmsize}</maxmemory>
<additionalparam>${javadoc.opts}</additionalparam>
<additionalOptions>${javadoc.opts}</additionalOptions>
</configuration>
<executions>
<execution>
Expand All @@ -456,20 +450,20 @@
<goals>
<goal>check</goal>
</goals>
<configuration>
<failOnViolation>true</failOnViolation>
<consoleOutput>true</consoleOutput>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<configLocation>check-style.xml</configLocation>
<suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
</execution>
</executions>
<configuration>
<failOnViolation>true</failOnViolation>
<consoleOutput>true</consoleOutput>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<configLocation>check-style.xml</configLocation>
<suppressionsLocation>checkstyle-suppressions.xml</suppressionsLocation>
</configuration>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>8.45.1</version>
<version>9.3</version>
</dependency>
</dependencies>
</plugin>
Expand Down Expand Up @@ -518,7 +512,7 @@
<artifactId>umlgraph</artifactId>
<version>5.6</version>
</docletArtifact>
<additionalparam>-views -all</additionalparam>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: additionalparam isn't available in maven-javadoc-plugin v3.

<additionalOptions>-views -all</additionalOptions>
<useStandardDocletOptions>true</useStandardDocletOptions>
</configuration>
</plugin>
Expand Down
Loading