Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up dependency libraries and etc / Improve pom.xml #329

Merged
merged 5 commits into from
Jul 1, 2024
Merged

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented Jun 28, 2024

Overview

  • Delete javax.annotation-api from dependency libraries
  • Update org.immutables:* to 2.10.1
  • Fix configurations in maven-javadoc-plugin
  • Upgrade checkstyle to v9

<scope>provided</scope>
</dependency>

<dependency>
<groupId>javax.annotation</groupId>
<artifactId>javax.annotation-api</artifactId>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the result when the command executes at the master branch.

~/I/td-client-java ❯❯❯ mvn dependency:analyze-only
[INFO] Scanning for projects...
[INFO]
[INFO] -----------------< com.treasuredata.client:td-client >------------------
[INFO] Building Treasure Data Client for Java 1.1.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-dependency-plugin:3.6.1:analyze-only (default-cli) @ td-client ---
[WARNING] Used undeclared dependencies found:
[WARNING]    com.google.code.findbugs:jsr305:jar:3.0.2:compile
[WARNING]    com.squareup.okio:okio:jar:1.17.2:compile
[WARNING]    org.hamcrest:hamcrest:jar:2.2:test
[WARNING]    io.netty:netty-codec-http:jar:4.1.86.Final:test
[WARNING]    io.netty:netty-transport:jar:4.1.86.Final:test
[WARNING] Unused declared dependencies found:
[WARNING]    javax.annotation:javax.annotation-api:jar:1.3.2:compile
[WARNING] Non-test scoped test only dependencies found:
[WARNING]    com.squareup.okio:okio:jar:1.17.2:compile
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  3.948 s
[INFO] Finished at: 2024-06-28T12:50:06+09:00
[INFO] ------------------------------------------------------------------------

@yuokada yuokada requested a review from muga June 28, 2024 03:52
yuokada added 2 commits June 28, 2024 13:10
* Upgrade checkstyle to v10

* Downgrade checkstyle to v9
@yuokada yuokada requested a review from tiana528 July 1, 2024 02:08
@yuokada yuokada marked this pull request as ready for review July 1, 2024 04:00
@yuokada yuokada changed the title Clean up dependency libraries Clean up dependency libraries and etc Jul 1, 2024
@yuokada yuokada changed the title Clean up dependency libraries and etc Clean up dependency libraries and etc / Improve pom.xml Jul 1, 2024
@@ -518,7 +512,7 @@
<artifactId>umlgraph</artifactId>
<version>5.6</version>
</docletArtifact>
<additionalparam>-views -all</additionalparam>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: additionalparam isn't available in maven-javadoc-plugin v3.

Copy link
Contributor

@tiana528 tiana528 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@yuokada yuokada merged commit d7ea2e5 into master Jul 1, 2024
7 checks passed
@yuokada yuokada deleted the cleanup-dep branch July 1, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants