-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release: 0.1.4 #32
Closed
Release: 0.1.4 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Exposes `TXStandardCache` `getCache` static method to Objective-C. * Updates Changelog and version
Expose getCache method to ObjC
Exposes the properties of `TXSourceString` making them public readonly so that other applications (like the Transifex CLI tool) can use them either by querying them or by extending the `TXSourceString` class. Ref: https://trello.com/c/1zQZUJ8E/48-cli-list-found-strings-on-push-command
Adds an optional argument to `TXNative.fetchTranslations` method (`tags`) that allows users to define a set of tags to use when fetching translations from CDS. If defined, CDS will only return content for strings that have all of the given tags. Adds unit test that expects the final URL sent to server to have a specific format. Ref: https://trello.com/c/eWgaL5BB/49-fetch-content-with-tags-only-on-runtime
…string_properties Expose TXSourceString properties
Fetch content with tags only
Given that CDS now allows the pulling of source content, changes had to be made to enable that functionality on the SDK. This commit changes the `CDSHandler` initialization by allowing it to accept all application locales that have been declared by the developer during the SDK initialization, which include the source locale. Updates translation logic to correctly support source and target locales and cover cases where the provided source string is not found on cache correctly. The missing policy in the `translate()` method is now applied after the `render()` so that any transformations by the missing policy will not affect the string interpolation. A new test has been added to test whether the source locale is fetched from the cache for a simple and a plural approach. * Introduces a public static `dispose()` method in the `TXNative` class, so that the `TXNative` singleton instance can be safely deconstructed in order for another `TXNative` instance to be initialized and used. * Calls the aforementioned `dispose()` method when each test ends (`tearDown`) so that the next unit test can properly initialize and use a new `TXNative` instance.
Allow the pull command to fetch source string content
Wrong version tag |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged Pull Requests:
#27 : Expose getCache method to ObjC
#29 : Expose TXSourceString properties
#30 : Fetch content with tags only
#28 : Allow the pull command to fetch source string content