Expose TXSourceString properties #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposes the properties of `TXSourceString` making them public readonly so that other applications (like the Transifex CLI tool) can use them either by querying them or by extending the `TXSourceString` class. Ref: https://trello.com/c/1zQZUJ8E/48-cli-list-found-strings-on-push-command
stelabouras
added a commit
to transifex/transifex-swift-cli
that referenced
this pull request
Jun 22, 2021
1. Updates `README` with clarification regarding the `verbose` argument conflict when running the CLI tool using the `swift run` command. 2. Adds `dryRun` flag so that the CLI tool won't actually send anything to CDS, which is useful for testing the command. 3. Removes the comment regarding ignoring the source locale when pulling strings from the CDS. 4. Styles the `TXSourceString` instances when printed (via the `debugDescription` property) accordingly. 3. Depends on transifex/transifex-swift#28 4. Depends on transifex/transifex-swift#29 Ref: https://trello.com/c/oIrxLJKg/47-cli-implement-dry-run-on-push https://trello.com/c/1zQZUJ8E/48-cli-list-found-strings-on-push-command
stelabouras
added a commit
to transifex/transifex-swift-cli
that referenced
this pull request
Jun 23, 2021
1. Updates `README` with clarification regarding the `verbose` argument conflict when running the CLI tool using the `swift run` command. 2. Adds `dryRun` flag so that the CLI tool won't actually send anything to CDS, which is useful for testing the command. 3. Removes the comment regarding ignoring the source locale when pulling strings from the CDS. 4. Styles the `TXSourceString` instances when printed (via the `debugDescription` property) accordingly. 3. Depends on transifex/transifex-swift#28 4. Depends on transifex/transifex-swift#29
stelabouras
added a commit
to transifex/transifex-swift-cli
that referenced
this pull request
Jun 23, 2021
1. Updates `README` with clarification regarding the `verbose` argument conflict when running the CLI tool using the `swift run` command. 2. Adds `dryRun` flag so that the CLI tool won't actually send anything to CDS, which is useful for testing the command. 3. Removes the comment regarding ignoring the source locale when pulling strings from the CDS. 4. Styles the `TXSourceString` instances when printed (via the `debugDescription` property) accordingly. 3. Depends on transifex/transifex-swift#28 4. Depends on transifex/transifex-swift#29
This was referenced Jun 25, 2021
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the properties of
TXSourceStringmaking them public readonlyso that other applications (like the Transifex CLI tool) can use them
either by querying them or by extending the
TXSourceStringclass.