Fixes trouble when setting archive output dir #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all path If the indented use was to copy the mingw .a files in the install path, it should be done inside the OCE_BUNDLE_AUTOINSTALL section. In MSVC is unnecessary.
|
This was the last commit at #456, I moved it to its own pull request because it looked controversial to me, and I wanted to merge other commits. Anyway, +1 from me. |
dbarbier
added a commit
that referenced
this pull request
Jan 27, 2014
Fixes trouble when setting archive output dir
camio
pushed a commit
to camio/oce
that referenced
this pull request
Mar 7, 2014
…ECTORY. If 'CMAKE_ARCHIVE_OUTPUT_DIRECTORY' is used to customize the output folders of oce-win-bundle libraries, the oce build will set FREETYPE_LIBRARY and related variables to the wrong paths. This patch fixes that bug. The commit that inserted this removal in the first place (tpaviot#465) did not provide any explination for it.
camio
pushed a commit
to camio/oce
that referenced
this pull request
Mar 9, 2014
…ECTORY. If 'CMAKE_ARCHIVE_OUTPUT_DIRECTORY' is used to customize the output folders of oce-win-bundle libraries, the oce build will set FREETYPE_LIBRARY and related variables to the wrong paths. This patch fixes that bug. The commit that inserted this removal in the first place (tpaviot#465) did not provide any explination for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the indented use was to copy the mingw .a files in the install path,
it should be done inside the OCE_BUNDLE_AUTOINSTALL section.
In MSVC this is unnecessary.