-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build improvements and fixes for MSVC #456
Conversation
@QbProg I was about to add a note to 531b049 saying to use |
BTW2: When using |
DrawText ends up to be defined as DrawTextA, and causes compilation failures.
Reviewed things like you suggested ( + lowercased commands) I still can't get tabs propertly, what was our convention anyway? About the BTW2: yes, it was the case but I recently added options in the bundle to disable FreeImage and GL2PS. (yep , that's something I effectively require :) |
Hi Qb, I've only taken the quickest glance at what you've changed, but for all your conditionals, could you please make sure they're as specific as possible? Meaning, if it's something for MSVC only, use the macro _MSC_VER instead of WNT, or some other MSVC specific macro. Many previous changes for MSVC had to be re-changed to make sure they only applied to MSVC and not MinGW. Thanks! |
GitHub mangled my message, meant |
Hello jacob, Qb 2014/1/13 Jacob Abel [email protected]
|
It is no more possible/simple to build TKService without freetype, as other classes (AIS_Dimension,etc...) depend on the font package.
Added autoinstall support for static library version of bundle
Good deal then, thanks.
|
+1 Hello @QbProg, I reviewed your changes and they look good. However, is it possible to move the last commit into a separate build request? I am afraid that we are playing ping pong here, and it will be easier to discuss this issue in a separate pull request. |
Build improvements and fixes for MSVC
This branch fixes various issues with MSVC compilation, with static libraries, TK, PDB files, bundle and source bundle.
The TKService w/o font support setting was removed as no more working.
I re-tested with MSVC2010, 2012, and 2013. 2013 should compile but the build system seems to be very much flawed and I was not able to complete a build.
This branch MAY break mingw support when OCE_USE_BUNDLE_SOURCE is active, as it used a very inconvenient setting about the ARCHIVE_OUTPUT_DIRECTORY.