Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trait bounds of Set{Request,Response}HeaderLayer constructors #147

Closed
wants to merge 1 commit into from
Closed

Update trait bounds of Set{Request,Response}HeaderLayer constructors #147

wants to merge 1 commit into from

Conversation

jplatte
Copy link
Collaborator

@jplatte jplatte commented Sep 18, 2021

#143 plus breaking change. I'll rebase once that is merged (just so GitHub doesn't show #143's commits as being part of this one anymore).

@davidpdrsn davidpdrsn added this to the 0.2.0 milestone Sep 18, 2021
@davidpdrsn davidpdrsn added the breaking change A PR that makes a breaking change. label Sep 18, 2021
None of them are actually needed but they should lead to better error messages
as the type checker can abort earlier when the make function doesn't fulfill
the bounds required for the types to actually be useful.
@jplatte
Copy link
Collaborator Author

jplatte commented Oct 4, 2021

Closing in favor of #148.

@jplatte jplatte closed this Oct 4, 2021
@jplatte jplatte deleted the improve-set-header-2 branch October 4, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change A PR that makes a breaking change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants