Improve set header #143
Merged
Improve set header #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The last commit is a breaking change due to adding / strengthening trait bounds. Other people could have replicated the strange previous bound (and lack of |
davidpdrsn
reviewed
Sep 18, 2021
|
Sure. Do you want to merge the rest of this PR on the command line or should I split the PR? |
|
I would appreciate it if you would split it. Then I can merge directly from GH. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Makes the code more maintainable, and docs neater (providing rustdoc with a clear tagline / rest of the docs for overview pages).
Solution
Refactor stuff.
Other
I didn't rename
TinSet{Request,Response}HeaderLayertoReqBody/ResBodyhere, but I think that might also make sense.All of this refactoring happened in an attempt to fix #127, which I still believe is possible but I've spent enough time on this for now.