Fix "Verify User Can Access Model Metrics From UWM" test in "Model Se…

…rving Llm" suite (red-hat-data-services#1755) * Add missing prometheus annotations * Check the model name from the beginning of the pod name --------- Co-authored-by: Milind Waykole <[email protected]>
tonyxrmdavidson · Sep 4, 2024 · 502f773 · 502f773
1 parent 1fe06e5
commit 502f773
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/ods_ci/tests/Resources/CLI/ModelServing/llm.resource b/ods_ci/tests/Resources/CLI/ModelServing/llm.resource
@@ -534,9 +534,9 @@ Check Query Response Values    # robocop:disable
             Log    message=Metrics source namespaced succesfully checked. Going to next step.
         END
         IF    "${exp_model_name}" != "${EMPTY}"
-            ${source_model}=    Set Variable    ${result["metric"]["job"]}
-            ${checked}=    Run Keyword And Return Status    Should Be Equal As Strings    ${source_model}
-            ...    ${exp_model_name}-metrics
+            ${source_pod}=    Set Variable    ${result["metric"]["pod"]}
+            ${checked}=    Run Keyword And Return Status    Should Start With    ${source_pod}
+            ...    ${exp_model_name}
             IF    ${checked} == ${FALSE}
                 Continue For Loop
             ELSE

diff --git a/ods_ci/tests/Resources/Files/llm/serving_runtimes/base/isvc.yaml b/ods_ci/tests/Resources/Files/llm/serving_runtimes/base/isvc.yaml
@@ -5,6 +5,8 @@ metadata:
     serving.knative.openshift.io/enablePassthrough: "true"
     sidecar.istio.io/inject: "true"
     sidecar.istio.io/rewriteAppHTTPProbers: "true"
+    prometheus.io/path: /metrics
+    prometheus.io/port: "3000"
   name: ${isvc_name}
 spec:
   predictor: