Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Verify User Can Access Model Metrics From UWM" test in "Model Serving Llm" suite #1755

Merged

Conversation

hdefazio
Copy link
Contributor

@hdefazio hdefazio commented Aug 28, 2024

  • RHOAIENG-11062: Fix "keyword TGI Caikit And Istio Metrics Should Exist" failure by adding missing prometheus annotations to the ISVC
  • RHOAIENG-11064: Fix "User Can Fetch Number Of Requests Over Defined Time" failure by changing the model_name comparison to use the pod name

Test Output:
sh run_robot_test.sh --skip-oclogin true --extra-robot-args '-i ODS-2401'

ods-2401

@hdefazio hdefazio marked this pull request as draft August 28, 2024 17:13
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
525 0 0 525 100

@hdefazio hdefazio marked this pull request as ready for review August 29, 2024 20:15
@hdefazio hdefazio requested a review from mwaykole August 29, 2024 20:26
Copy link

@mwaykole
Copy link
Member

image

tested and verified job/rhoai-test-flow/21/console

@mwaykole mwaykole enabled auto-merge (squash) August 30, 2024 04:40
@mwaykole mwaykole added the verified This PR has been tested with Jenkins label Aug 30, 2024
@mwaykole mwaykole merged commit 61c98fb into red-hat-data-services:master Aug 30, 2024
10 checks passed
jgarciao pushed a commit to jgarciao/ods-ci that referenced this pull request Sep 1, 2024
…rving Llm" suite (red-hat-data-services#1755)

* Add missing prometheus annotations

* Check the model name from the beginning of the pod name

---------

Co-authored-by: Milind Waykole <[email protected]>
tonyxrmdavidson pushed a commit to tonyxrmdavidson/ods-ci that referenced this pull request Sep 4, 2024
…rving Llm" suite (red-hat-data-services#1755)

* Add missing prometheus annotations

* Check the model name from the beginning of the pod name

---------

Co-authored-by: Milind Waykole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified This PR has been tested with Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants