fix clippy linting recommendations (edition 2018) #581
Conversation
|
@chetaldrich looks like you may need to run rustfmt, ci is failing. |
|
Ok, I'll give that a go quick. Thanks for getting the CI to run! |
|
@LucioFranco I ran rustfmt, so should be good to give CI another run. |
It turns out you get a compilation error on Rust 1.51.0 if you use the `split_once` and `rsplit_once` methods since they were unstable at that version. In Rust stable (currently 1.58.1), there are clippy recommendations that say to use those methods instead of `rsplitn` and `splitn` if you're only splitting once. I figured the best way to handle this since we're targeting 1.51 in addition to stable is to just set specific ignore in that case so the old version still compiles successfully.
|
It turns out you get a compilation error on Rust 1.51.0 if you use the In Rust stable (currently 1.58.1), there are clippy recommendations that I figured the best way to handle this since we're targeting 1.51 in addition to stable is to just set specific ignore in that case so the old version still compiles successfully. Should be good for another CI run @LucioFranco, thanks for being prompt about the last one! |
|
Looks like we're good now! If you have any other comments @LucioFranco let me know. |
Figured I'd start with recommendations in the current codebase as is, and that'll make handling #553 a bit easier.