Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy warnings introduced with 2021 edition #553

Closed
LucioFranco opened this issue Oct 25, 2021 · 6 comments · Fixed by #688
Closed

Fix clippy warnings introduced with 2021 edition #553

LucioFranco opened this issue Oct 25, 2021 · 6 comments · Fixed by #688
Labels
help wanted

Comments

@LucioFranco
Copy link
Member

No description provided.

@chetaldrich
Copy link
Contributor

So I looked into this just because I was curious, and noticed that there were a decent number of warnings already showing up without changing the edition. Would you be willing to take a look at a PR that addresses existing warnings?

@chetaldrich chetaldrich mentioned this issue Jan 7, 2022
Merged
@chetaldrich
Copy link
Contributor

I gave it a whirl. If you have a chance to take a look at some point I'd appreciate it!

@chetaldrich
Copy link
Contributor

Just to follow up on this, it seems like moving up from edition 2018 to 2021 causes problems because edition 2021 was unstable at the time of release of rustc 1.51, and therefore doesn't successfully compile. So we're kinda stuck here until we can up the MSRV to 1.56, which is when edition 2021 was introduced.

Given the MSRV must be from at least 6 months ago, that means we can set 1.56 as the MSRV to address this on April 21, 2022 or later. (1.56 was released on Oct 21, 2021).

@chetaldrich
Copy link
Contributor

That being said, we can fix clippy errors with 2021 in stable, we just can't set the library to 2021.

@LucioFranco
Copy link
Member Author

Yeah I am good to fix clippy errors, we can follow up on the edition update.

chetaldrich added a commit to chetaldrich/prost that referenced this issue Mar 3, 2022
@chetaldrich
fix edition 2021 clippy errors
4631455 
This handles the clippy error that showed up when switching over
to edition 2021. Note that we can't move to use edition 2021 until
the MSRV is set to 1.56. See tokio-rs#553 for
more details.
@chetaldrich chetaldrich mentioned this issue Mar 3, 2022
Merged
chetaldrich added a commit to chetaldrich/prost that referenced this issue Jul 24, 2022
@chetaldrich
move edition to 2021
702d52a 
Looks like since I've last looked at the repo, the update to
MSRV 1.56 happened, and we don't have any clippy errors on the 2021
edition, so I _think_ we can just up this value now.

Closes tokio-rs#553
@chetaldrich chetaldrich mentioned this issue Jul 24, 2022
Merged
@chetaldrich
Copy link
Contributor

I went ahead and followed up with that edition update so we can close this out.

LucioFranco added a commit that referenced this issue Jul 29, 2022
@chetaldrich @LucioFranco
Move edition to 2021 (#688)
11b5406 
Closes #553

Co-authored-by: Lucio Franco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move edition to 2021 chetaldrich/prost
2 participants
@LucioFranco @chetaldrich