apply recursion limit when skipping fields #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
referenced
this pull request
in linkerd/linkerd2-proxy
Jan 23, 2020
This branch updates the proxy's `prost` dependency to a patched version of `prost` 0.5 that incorporates the cahnges in danburkert/prost#268. This patch fixes a security issue where a malicious protobuf message could be used to trigger a stack overflow. We are unfortunately unable to easily update to `prost` 0.6.1, which includes this fix, as 0.6 updates the `bytes` dependency to 0.5. The `tokio` 0.1 ecosystem that the proxy currently uses still depends on 0.4, and the breaking changes in 0.5 are quite significant. Therefore, updating to `bytes` 0.5 would require a lot of fairly large changes to legacy versions of...pretty much everything (`tokio-io`, `tokio-buf`, `hyper`, `http-body`...). As we intend to update to `tokio` 0.2 in the near future, patching all these legacy dependencies is a bit of a waste of time. Therefore, I opted to backport the security fix to a compatible `prost` version instead. Closes inkerd/linkerd2#3963 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
referenced
this pull request
in linkerd/linkerd2-proxy
Jan 23, 2020
This branch updates the proxy's `prost` dependency to a patched version of `prost` 0.5 that incorporates the cahnges in danburkert/prost#268. This patch fixes a security issue where a malicious protobuf message could be used to trigger a stack overflow. We are unfortunately unable to easily update to `prost` 0.6.1, which includes this fix, as 0.6 updates the `bytes` dependency to 0.5. The `tokio` 0.1 ecosystem that the proxy currently uses still depends on 0.4, and the breaking changes in 0.5 are quite significant. Therefore, updating to `bytes` 0.5 would require a lot of fairly large changes to legacy versions of...pretty much everything (`tokio-io`, `tokio-buf`, `hyper`, `http-body`...). As we intend to update to `tokio` 0.2 in the near future, patching all these legacy dependencies is a bit of a waste of time. Therefore, I opted to backport the security fix to a compatible `prost` version instead. Closes inkerd/linkerd2#3963 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
referenced
this pull request
in linkerd/linkerd2-proxy
Jan 23, 2020
This branch updates the proxy's `prost` dependency to a patched version of `prost` 0.5 that incorporates the cahnges in danburkert/prost#268. This patch fixes a security issue where a malicious protobuf message could be used to trigger a stack overflow. We are unfortunately unable to easily update to `prost` 0.6.1, which includes this fix, as 0.6 updates the `bytes` dependency to 0.5. The `tokio` 0.1 ecosystem that the proxy currently uses still depends on 0.4, and the breaking changes in 0.5 are quite significant. Therefore, updating to `bytes` 0.5 would require a lot of fairly large changes to legacy versions of...pretty much everything (`tokio-io`, `tokio-buf`, `hyper`, `http-body`...). As we intend to update to `tokio` 0.2 in the near future, patching all these legacy dependencies is a bit of a waste of time. Therefore, I opted to backport the security fix to a compatible `prost` version instead. Closes linkerd/linkerd2#3963 Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267