Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
patch
prost
0.5 to pick up security fix
This branch updates the proxy's `prost` dependency to a patched version of `prost` 0.5 that incorporates the cahnges in danburkert/prost#268. This patch fixes a security issue where a malicious protobuf message could be used to trigger a stack overflow. We are unfortunately unable to easily update to `prost` 0.6.1, which includes this fix, as 0.6 updates the `bytes` dependency to 0.5. The `tokio` 0.1 ecosystem that the proxy currently uses still depends on 0.4, and the breaking changes in 0.5 are quite significant. Therefore, updating to `bytes` 0.5 would require a lot of fairly large changes to legacy versions of...pretty much everything (`tokio-io`, `tokio-buf`, `hyper`, `http-body`...). As we intend to update to `tokio` 0.2 in the near future, patching all these legacy dependencies is a bit of a waste of time. Therefore, I opted to backport the security fix to a compatible `prost` version instead. Closes inkerd/linkerd2#3963 Signed-off-by: Eliza Weisman <[email protected]>
- Loading branch information