fix(blocks): switch the file-type to @sgtpooki/file-type #6803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
fourdim
reviewed
Apr 18, 2024
There was a problem hiding this comment.
It still depends on buffer: sindresorhus/file-type#578.
The only solution is to reimplement file-type.
|
I also tried upgrading file-type package but got this error in AFFiNE. |
lawvs
force-pushed
the
chore/upgrade-file-type
branch
from
7d72f3a to
42257ef
Compare
lawvs
changed the title
EYHN
reviewed
Apr 18, 2024
| if (!blob) { | ||
| return null; | ||
| } | ||
|
|
||
| if (!blob.type) { |
There was a problem hiding this comment.
I suggest that we not delete file-type, because affine's sync backend does not store blob.type. You can expect all blob.types to be empty "". We can only calculate them through file-type when type is needed.
As for the buffer issue of file-type v19 in the browser, affine can workaround by adding node:buffer polyfill.
lawvs
force-pushed
the
chore/upgrade-file-type
branch
from
8bd528b to
9e08d39
Compare
lawvs
force-pushed
the
chore/upgrade-file-type
branch
from
9e08d39 to
43645ce
Compare
lawvs
changed the title
lawvs
force-pushed
the
chore/upgrade-file-type
branch
from
43645ce to
d85ec8d
Compare
fourdim
approved these changes
Apr 19, 2024
EYHN
approved these changes
Apr 22, 2024
Merge activity
|
Fix toeverything/AFFiNE#6603 This pull request switches the [file-type](https://github.com/sindresorhus/file-type) to [@sgtpooki/file-type](https://github.com/sgtpooki/file-type). It also includes other minor changes and updates. ~~The `file-type` is no longer useful since the toeverything/AFFiNE#3245 resolved in toeverything/AFFiNE#5565 --- More context see toeverything/AFFiNE#3245 #3555 #4818 #5372 sindresorhus/file-type#578 --- ## Caveat The [@sgtpooki/file-type](https://github.com/sgtpooki/file-type) is an unofficial fork package from the community. It may need to be source code audited before updating. Also, thanks to sgtpooki for their strong contribution to @sgtpooki/file-type
EYHN
force-pushed
the
chore/upgrade-file-type
branch
from
d85ec8d to
7664f3e
Compare
EYHN
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Apr 23, 2024
## Features - toeverything/blocksuite#6842 @donteatfriedrice - toeverything/blocksuite#6836 @regischen ## Bugfix - toeverything/blocksuite#6837 @pengx17 - toeverything/blocksuite#6803 @lawvs - toeverything/blocksuite#6843 @donteatfriedrice - toeverything/blocksuite#6838 @donteatfriedrice - toeverything/blocksuite#6834 @regischen - toeverything/blocksuite#6835 @donteatfriedrice - toeverything/blocksuite#6831 @pengx17 - toeverything/blocksuite#6827 @golok727 - toeverything/blocksuite#6828 @regischen ## Refactor ## Misc
1 task
fourdim
pushed a commit
that referenced
this pull request
Jul 10, 2024
This pull request is for sunsetting the `@sgtpooki/file-type` and using the official file-type v19.1.0. The `file-type` package has replaced the usage of `node:buffer` with `Uint8Array`. This change allows it to run safely in the browser now. The file-type package is used in the attachment-block and image-block modules to determine the file type of uploaded files. Related to #6803 sindresorhus/file-type#578 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix toeverything/AFFiNE#6603
This pull request switches the file-type to @sgtpooki/file-type.
It also includes other minor changes and updates.
Thefile-typeis no longer useful since the toeverything/AFFiNE#3245 resolved in toeverything/AFFiNE#5565More context see toeverything/AFFiNE#3245 #3555 #4818 #5372 sindresorhus/file-type#578
Caveat
The @sgtpooki/file-type is an unofficial fork package from the community. It may need to be source code audited before updating.
Also, thanks to sgtpooki for their strong contribution to @sgtpooki/file-type