-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use sgtpooki/file-type for resolving image type #7326
fix: use sgtpooki/file-type for resolving image type #7326
Conversation
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7b181a6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #7326 +/- ##
===========================================
- Coverage 58.30% 28.33% -29.98%
===========================================
Files 854 654 -200
Lines 37714 14938 -22776
Branches 4086 2626 -1460
===========================================
- Hits 21990 4233 -17757
+ Misses 15430 10461 -4969
+ Partials 294 244 -50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this library is ridiculous, can we really trust it?
There could be other image types like webp that we may also need to introduce soon. Besides blocksuite already has its as the dependency in https://github.com/toeverything/blocksuite/blob/45bdebd333aef568fd4c0e7bd5aebf9e6a8662f0/packages/blocks/src/attachment-block/utils.ts#L185. |
@pengx17 I dont know the reason but why don't we use |
More context: |
I prefer easily patching file-type with yarn by our own |
I also tried patch, but the reference to |
4f98f0b
to
0d96148
Compare
0d96148
to
7b181a6
Compare
No description provided.