Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mdfix #209

Merged
merged 4 commits into from
Sep 5, 2019
Merged

Mdfix #209

merged 4 commits into from
Sep 5, 2019

Conversation

tlienart
Copy link
Owner

@tlienart tlienart commented Sep 5, 2019

closes #205 and #206 with proper handling of

  • backslashes including the special \\ which, as in LaTex, forces a line return
  • escaping of backtick doesn't error anymore
  • usage of html entities now works

(also moderate clean up of some tests, introduction of explore_md_steps and explore_h_steps to cleanly explore what's being done in the respective parsing steps at test time)

@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #209 into master will decrease coverage by 0.1%.
The diff coverage is 88.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   87.03%   86.92%   -0.11%     
==========================================
  Files          26       28       +2     
  Lines        1118     1132      +14     
==========================================
+ Hits          973      984      +11     
- Misses        145      148       +3
Impacted Files Coverage Δ
src/JuDoc.jl 100% <ø> (ø) ⬆️
src/migration/jekyll.jl 0% <0%> (ø)
src/converter/md_blocks.jl 96.77% <100%> (ø) ⬆️
src/converter/md.jl 98.11% <100%> (+0.01%) ⬆️
src/converter/md_utils.jl 100% <100%> (ø) ⬆️
src/parser/md_tokens.jl 100% <100%> (ø) ⬆️
src/parser/tokens.jl 98.14% <87.5%> (-1.86%) ⬇️
src/parser/md_chars.jl 88.88% <88.88%> (ø)
src/converter/lx.jl 95.57% <0%> (-0.04%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57c229a...d0fec9d. Read the comment docs.

@tlienart tlienart merged commit 0e65839 into master Sep 5, 2019
@tlienart tlienart deleted the mdfix branch September 5, 2019 11:50
This was referenced Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backslash and escaping issues
1 participant