Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Inline code blocks are rendered incorrectly #198

Closed
cserteGT3 opened this issue Aug 20, 2019 · 2 comments
Closed

[BUG] Inline code blocks are rendered incorrectly #198

cserteGT3 opened this issue Aug 20, 2019 · 2 comments
Assignees
Labels
bug Something isn't working easy md-parse

Comments

@cserteGT3
Copy link
Contributor

Example from index.md of a freshly generated site:

### LaTeX and Maths

Essentially three things are imitated from LaTeX

1. you can introduce definitions using `\newcommand`
1. you can use hyper-references with `\eqref`, `\cite`, ...
1. you can show nice maths (via KaTeX)

should be rendered like:

LaTeX and Maths

Essentially three things are imitated from LaTeX

  1. you can introduce definitions using \newcommand
  2. you can use hyper-references with \eqref, \cite, ...
  3. you can show nice maths (via KaTeX)

but looks like the following (note that this is edited by hand):

LaTeX and Maths

Essentially three things are imitated from LaTeX

  1. you can introduce definitions using
    newcommand
  2. you can use hyper-references with
    eqref,
    cite, ...
  3. you can show nice maths (via KaTeX)

This happens on #master, but not on v0.2.0.

@cserteGT3 cserteGT3 changed the title [BUG] Inline code blocks are endered incorrectly [BUG] Inline code blocks are rendered incorrectly Aug 21, 2019
@tlienart
Copy link
Owner

Thanks for this, it's another one of those where <p> are inserted and should not. I'll investigate and fix asap

@tlienart tlienart added bug Something isn't working easy md-parse labels Aug 22, 2019
@tlienart tlienart self-assigned this Aug 22, 2019
@tlienart
Copy link
Owner

tlienart commented Sep 5, 2019

Ok this is now fixed, the issue is described in #205 and solved in #209 (and tested explicitly in #212) ; on master the following:

Essentially three things are imitated from LaTeX
1. you can introduce definitions using `\newcommand`
1. you can use hyper-references with `\eqref`, `\cite`, ...
1. you can show nice maths (via KaTeX)

becomes

<p>Essentially three things are imitated from LaTeX</p>
<ol>
    <li><p>you can introduce definitions using <code>\newcommand</code></p></li>
    <li><p>you can use hyper-references with <code>\eqref</code>, <code>\cite</code>, ...</p></li>
    <li><p>you can show nice maths &#40;via KaTeX&#41;</p></li>
</ol>

So there's no spurious insertions of <br/> that caused the line skipping you reported.

Thanks for the report!

tlienart added a commit that referenced this issue Sep 5, 2019
@tlienart tlienart mentioned this issue Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working easy md-parse
Projects
None yet
Development

No branches or pull requests

2 participants