Add target components logic to pipelines #1173
Conversation
|
🚀 Deployed on https://deploy-preview-1173--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 86.93% 86.79% -0.14%
==========================================
Files 177 166 -11
Lines 10063 9785 -278
==========================================
- Hits 8748 8493 -255
+ Misses 1315 1292 -23
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -252,7 +252,7 @@ def test_forecast_calls_process_forecasts(example_tsds: TSDataset, naive_ensembl | |||
| naive_ensemble.fit(ts=example_tsds) | |||
| naive_ensemble._process_forecasts = MagicMock() | |||
|
|
|||
| result = naive_ensemble._forecast() | |||
| result = naive_ensemble._forecast(return_components=False) | |||
There was a problem hiding this comment.
Why should we add return_components=False here? Is it because we don't have default value here?
There was a problem hiding this comment.
Yes, as return_components should be passed from the public method, otherwise we might forget to pass it and everything will still work
Before submitting (must do checklist)
Proposed Changes
Closing issues
closes #1167