You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add target components logic to pipelines to the base classes of our pipelines
Proposal
In all the classes from folders ensembles, pipeline:
In methods _forecast, _predict add flag
return_components: bool
In methods forecast, predict add flag
return_components: bool = False
Add NotImplemented error for the case return_components=True
In BasePipeline pass return_components flag in forecast, predict into _forecast, _predict
In ModelPipelinePredictMixin pass return_components flag in _predict into the model's predict method
In Pipeline pass return_components flag in the necessary places inside the forecast and _forecast
Test cases
Run this test cases for dummy implementation of NonPredictionIntervalContextIgnorantAbstractModel, NonPredictionIntervalContextRequiredAbstractModel, PredictionIntervalContextIgnorantAbstractModel, PredictionIntervalContextRequiredAbstractModel. There should be different implementation for forecast and predict (i.e. return different constants).
For Pipeline check that when return_components=True dataset contain the correct target components for methods forecast, predict for dummy implementations
For all the other pipelines check that they throw Notimplemented on return_components=True
Additional context
No response
The text was updated successfully, but these errors were encountered:
🚀 Feature Request
Add target components logic to pipelines to the base classes of our pipelines
Proposal
ensembles
,pipeline
:_forecast
,_predict
add flagforecast
,predict
add flagreturn_components=True
BasePipeline
passreturn_components
flag inforecast
,predict
into_forecast
,_predict
ModelPipelinePredictMixin
passreturn_components
flag in_predict
into the model'spredict
methodPipeline
passreturn_components
flag in the necessary places inside theforecast
and_forecast
Test cases
Run this test cases for dummy implementation of
NonPredictionIntervalContextIgnorantAbstractModel
,NonPredictionIntervalContextRequiredAbstractModel
,PredictionIntervalContextIgnorantAbstractModel
,PredictionIntervalContextRequiredAbstractModel
. There should be different implementation forforecast
andpredict
(i.e. return different constants).For
Pipeline
check that whenreturn_components=True
dataset contain the correct target components for methodsforecast
,predict
for dummy implementationsFor all the other pipelines check that they throw Notimplemented on
return_components=True
Additional context
No response
The text was updated successfully, but these errors were encountered: