Skip to content

Add target components logic to pipelines #1167

Closed
alex-hse-repository opened this issue Mar 15, 2023 · 0 comments · Fixed by #1173
Closed

Add target components logic to pipelines #1167

alex-hse-repository opened this issue Mar 15, 2023 · 0 comments · Fixed by #1173
Assignees
Labels
enhancement New feature or request

Comments

@alex-hse-repository
Copy link
Collaborator

alex-hse-repository commented Mar 15, 2023

🚀 Feature Request

Add target components logic to pipelines to the base classes of our pipelines

Proposal

  1. In all the classes from folders ensembles, pipeline:
  • In methods _forecast, _predict add flag
return_components: bool
  • In methods forecast, predict add flag
return_components: bool = False
  • Add NotImplemented error for the case return_components=True
  1. In BasePipeline pass return_components flag in forecast, predict into _forecast, _predict
  2. In ModelPipelinePredictMixin pass return_components flag in _predict into the model's predict method
  3. In Pipeline pass return_components flag in the necessary places inside the forecast and _forecast

Test cases

Run this test cases for dummy implementation of NonPredictionIntervalContextIgnorantAbstractModel, NonPredictionIntervalContextRequiredAbstractModel, PredictionIntervalContextIgnorantAbstractModel, PredictionIntervalContextRequiredAbstractModel. There should be different implementation for forecast and predict (i.e. return different constants).

  1. For Pipeline check that when return_components=True dataset contain the correct target components for methods forecast, predict for dummy implementations

  2. For all the other pipelines check that they throw Notimplemented on return_components=True

Additional context

No response

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Mar 15, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Mar 15, 2023
@alex-hse-repository alex-hse-repository moved this from Specification to Todo in etna board Mar 16, 2023
@alex-hse-repository alex-hse-repository moved this from Todo to In Progress in etna board Mar 17, 2023
@alex-hse-repository alex-hse-repository self-assigned this Mar 17, 2023
@martins0n martins0n moved this from In Progress to In Review in etna board Mar 20, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant