Skip to content

*: put gRPC unknown error into the header. (#5310) #6724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

nolouch
Copy link
Contributor

@nolouch nolouch commented Jun 30, 2023

Issue Number: Ref #5309. Close #5161 pingcap/tiflash#7408
pick #5310

What is changed and how does it work?

put the unknown error into the header instead of directly returning a gRPC error.

Check List

Tests

  • Unit test

Release note

Put the unknown error into the header instead of directly returning a gRPC error.
And modify related uint tests and code.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 30, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved labels Jun 30, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx June 30, 2023 03:18
@nolouch
Copy link
Contributor Author

nolouch commented Jun 30, 2023

ref pingcap/tiflash#7408

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 30, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 30, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 30, 2023
@nolouch nolouch force-pushed the pick-5310 branch 2 times, most recently from 4144c29 to c7888c2 Compare June 30, 2023 03:56
close tikv#5161, ref tikv#5161

put the unknown error into the header instead of directly returning a gRPC error.

Signed-off-by: husharp <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 30, 2023
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage: 25.56% and project coverage change: -0.25 ⚠️

Comparison is base (0be684b) 75.70% compared to head (886f415) 75.46%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.1    #6724      +/-   ##
===============================================
- Coverage        75.70%   75.46%   -0.25%     
===============================================
  Files              307      307              
  Lines            30506    30567      +61     
===============================================
- Hits             23094    23066      -28     
- Misses            5432     5498      +66     
- Partials          1980     2003      +23     
Flag Coverage Δ
unittests 75.46% <25.56%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/api/member.go 52.38% <0.00%> (-0.85%) ⬇️
server/tso/global_allocator.go 61.45% <0.00%> (-1.31%) ⬇️
server/grpc_service.go 50.45% <19.31%> (-1.21%) ⬇️
tests/cluster.go 79.33% <25.00%> (-1.08%) ⬇️
client/client.go 69.33% <38.46%> (+1.00%) ⬆️
client/base_client.go 80.71% <100.00%> (+0.29%) ⬆️
server/tso/allocator_manager.go 63.69% <100.00%> (-2.20%) ⬇️

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nolouch
Copy link
Contributor Author

nolouch commented Jun 30, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 30, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 30, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 886f415

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 30, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3dc0cc3 into tikv:release-6.1 Jun 30, 2023
@nolouch nolouch deleted the pick-5310 branch June 30, 2023 06:02
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants