-
Notifications
You must be signed in to change notification settings - Fork 728
*: put gRPC unknown error into the header. (#5310) #6724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
4144c29
to
c7888c2
Compare
close tikv#5161, ref tikv#5161 put the unknown error into the header instead of directly returning a gRPC error. Signed-off-by: husharp <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-6.1 #6724 +/- ##
===============================================
- Coverage 75.70% 75.46% -0.25%
===============================================
Files 307 307
Lines 30506 30567 +61
===============================================
- Hits 23094 23066 -28
- Misses 5432 5498 +66
- Partials 1980 2003 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 886f415
|
This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue Number: Ref #5309. Close #5161 pingcap/tiflash#7408
pick #5310
What is changed and how does it work?
Check List
Tests
Release note