-
Notifications
You must be signed in to change notification settings - Fork 728
Normalize the gRPC error handling #5309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe not bother to add new error types. |
Yes, the current task is to fix the PD's gRPC error handling according to this rule. Other normalizing work is more long-term or expected to be done sometime in the future. |
close #5161, ref #5309, ref #5310, ref pingcap/tiflash#7408 put the unknown error into the header instead of directly returning a gRPC error. Signed-off-by: husharp <[email protected]> Co-authored-by: Hu# <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
As #5161 and tikv/tikv#12345 show, the gRPC error handling of PD is arbitrary. We mix using the gRPC error code and response header to return the error, which causes the TiKV may reconnect the PD incorrectly and unnecessarily. This is the tracking issue for normalizing the gRPC error handling of PD.
TODOs
The text was updated successfully, but these errors were encountered: