tso, server, tests: add a test case for tso allocation bug #2675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <[email protected]>
JmPotato
added
component/testing
Signed-off-by: JmPotato <[email protected]>
disksing
reviewed
Jul 23, 2020
Signed-off-by: JmPotato <[email protected]>
disksing
approved these changes
Jul 23, 2020
nolouch
reviewed
Jul 23, 2020
ti-srebot
approved these changes
Jul 23, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/pd
that referenced
this pull request
Jul 23, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #2678 |
nolouch
pushed a commit
that referenced
this pull request
Jul 27, 2020
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Haizhi Geng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
Previous PR #2665 tries to fix a bug that tso allocation may fail though it's already a PD leader, which lacks of a test case can cover this situation. This pr adds a test case and makes some slight changes than before.
According to these two TiDB jenkins tests, tso may still have some problems when leader changes. I need more logs to figure out why, so this pr also adds some log info when a tso request arrive.
What is changed and how it works?
leaseas soon as possible inSyncTimestamp.Serverfor test purpose.Check List
Tests
Related changes
Release note
Add more tests and logs for TSO request.