Skip to content

TSO request may fail at the time of leader changing #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JmPotato opened this issue Jul 16, 2020 · 2 comments · Fixed by #2665 or #2675
Closed

TSO request may fail at the time of leader changing #2663

JmPotato opened this issue Jul 16, 2020 · 2 comments · Fixed by #2665 or #2675
Assignees
@JmPotato
Labels
status/TODO The issue will be done in the future. type/bug The issue is confirmed as a bug.

Comments

@JmPotato
Copy link
Member

JmPotato commented Jul 16, 2020 •
edited
Loading

Bug Report

Under the current latest version of PD, TSO request may fail at the time of leader changing because SyncTimestamp is not yet completed but PD receives a TSO request at the same time. To fix this, we may need to check the leader lease and retry when loading TSO in memory fails rather than just return an error.

image

Notice for reopening

I reopen this issue because this bug still exists in the normal leader changing case. We may need to add a retry mechanism for PD client to address this question totally.
@JmPotato JmPotato added the type/bug The issue is confirmed as a bug. label Jul 16, 2020
@JmPotato JmPotato self-assigned this Jul 16, 2020
@JmPotato JmPotato added the status/TODO The issue will be done in the future. label Jul 16, 2020
@JmPotato JmPotato mentioned this issue Jul 17, 2020
Merged
@ti-srebot ti-srebot mentioned this issue Jul 20, 2020
Merged
@JmPotato JmPotato linked a pull request Jul 22, 2020 that will close this issue
tso, server, tests: add a test case for tso allocation bug #2675
Merged
@JmPotato JmPotato reopened this Aug 14, 2020
@JmPotato JmPotato mentioned this issue Aug 24, 2020
Merged
@nolouch
Copy link
Contributor

nolouch commented Aug 25, 2020

Has it been fixed?

@JmPotato
Copy link
Member Author

Fixed by pingcap/tidb#19382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmPotato JmPotato

Labels
status/TODO The issue will be done in the future. type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
2 participants
@JmPotato @nolouch