feat: Add vendored support #411
Conversation
Signed-off-by: Xuanwo <[email protected]>
Xuanwo
force-pushed
the
add-vendor-support
branch
from
53bf03c to
36fccfd
Compare
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
|
Should wait for #412 |
|
cc @andylokandy, @ekexium & @pingyu, would you like to take a review? Thanks! |
There was a problem hiding this comment.
without install PROTOC
I'd prefer to bundle PROTOC or use protobuf-src instead. Like what is done in tikv/protobuf-build#67
|
Vendor generated looks like a step backward. If you do want to decouple with a PROTOC from the user side, it should be the default manner instead of a feature flag. That is, we always generated, ship the generated, and check the generated updated with CI. |
We need a feature flag if we want to do this in Current design is:
|
Signed-off-by: Xuanwo <[email protected]>
Signed-off-by: Xuanwo <[email protected]>
|
cc @tisonkun, would you like to take a review again? |
|
@Xuanwo Perhaps you can ping @andylokandy for a review. Or before we call any release, I can merge it now. |
|
Thanks! |
| tonic_build::configure() | ||
| .disable_doctests_for_types([".google.api.HttpRule"]) | ||
| .emit_rerun_if_changed(false) |
There was a problem hiding this comment.
By the way, it's interesting to know why the auto rerun is disabled.
There was a problem hiding this comment.
By the way, it's interesting to know why the auto rerun is disabled.
After this change, we are running codegen in a new bin instead of build.rs, the rerun hint for cargo is not working anymore. Instead, they just print to the console.
Close #410