Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/tikv): introduce new service backend tikv #2565

Merged
merged 12 commits into from
Jul 23, 2023
Merged

feat(services/tikv): introduce new service backend tikv #2565

merged 12 commits into from
Jul 23, 2023

Conversation

oowl
Copy link
Member

@oowl oowl commented Jun 28, 2023

No description provided.

@oowl
Copy link
Member Author

oowl commented Jun 28, 2023

blocked by tikv/client-rust#395 (comment)

@oowl oowl marked this pull request as draft June 28, 2023 17:47
@Xuanwo
Copy link
Member

Xuanwo commented Jul 9, 2023

TiKV has migrated it's grpc client to tonic at tikv/client-rust#399

We will need to wait for tikv 0.3

@oowl oowl force-pushed the feat/service/tikv branch from b98844b to c4b8aba Compare July 11, 2023 03:07
@Xuanwo
Copy link
Member

Xuanwo commented Jul 13, 2023

tikv_client v0.2 has been released, let's rock: https://docs.rs/tikv-client/latest/tikv_client/

@oowl oowl force-pushed the feat/service/tikv branch 2 times, most recently from eec849a to 1a51fff Compare July 13, 2023 17:22
@oowl oowl marked this pull request as ready for review July 13, 2023 17:22
@oowl
Copy link
Member Author

oowl commented Jul 13, 2023

I will add test action in another PR.

Xuanwo
Xuanwo reviewed Jul 13, 2023
View reviewed changes
core/src/services/mod.rs Outdated Show resolved Hide resolved
core/src/services/tikv/backend.rs Outdated Show resolved Hide resolved
core/src/services/tikv/backend.rs Outdated Show resolved Hide resolved
core/src/services/tikv/backend.rs Outdated Show resolved Hide resolved
core/src/services/tikv/backend.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo reviewed Jul 13, 2023
View reviewed changes
core/Cargo.toml Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented Jul 13, 2023

I submitted a PR tikv/client-rust#411 to remove the need of PROTOC.

@oowl oowl marked this pull request as draft July 14, 2023 03:38
@Xuanwo
Copy link
Member

Xuanwo commented Jul 20, 2023

Hi, @oowl, I have added protoc in #2674. Would you like to take another try?

@oowl oowl force-pushed the feat/service/tikv branch from 609f85f to 07c89a6 Compare July 23, 2023 07:16
@oowl
Copy link
Member Author

oowl commented Jul 23, 2023

I will add tikv integration test in next PR.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 23, 2023

I will add tikv integration test in next PR.

LGTM.

@oowl oowl marked this pull request as ready for review July 23, 2023 09:15
@oowl oowl force-pushed the feat/service/tikv branch from 1fdc0a8 to 9ba4465 Compare July 23, 2023 09:16
@oowl oowl requested a review from Xuanwo July 23, 2023 09:21
Xuanwo
Xuanwo reviewed Jul 23, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, great PR!

core/src/services/tikv/backend.rs Outdated Show resolved Hide resolved
core/src/services/tikv/backend.rs Show resolved Hide resolved
@oowl oowl force-pushed the feat/service/tikv branch from 9ba4465 to cfaadf7 Compare July 23, 2023 10:23
@Xuanwo
Copy link
Member

Xuanwo commented Jul 23, 2023

Great, let's go!

@Xuanwo Xuanwo merged commit 6fd6697 into apache:main Jul 23, 2023
@Xuanwo Xuanwo mentioned this pull request Jul 23, 2023
Closed
7 tasks
This was referenced Jul 24, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oowl @Xuanwo