Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

region_cache: support <engine_role, write> for disaggregated tiflash #728

Merged
merged 4 commits into from
Mar 7, 2023
Merged

region_cache: support <engine_role, write> for disaggregated tiflash #728

merged 4 commits into from
Mar 7, 2023

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Mar 6, 2023 •
edited
Loading

  1. Add LabelFilter for getTiFlashRPCContext, GetTiFlashStores() and GetAllValidTiFlashStores

@guo-shaoge
Copy link
Contributor Author

guo-shaoge commented Mar 7, 2023 •
edited
Loading

tidb-compatibility can skip for now, becase tidb pr will merge later. TiDB pr:pingcap/tidb#41958

JaySon-Huang
JaySon-Huang approved these changes Mar 7, 2023
View reviewed changes
Copy link

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guo-shaoge guo-shaoge mentioned this pull request Mar 7, 2023
Merged
12 tasks
@gengliqi gengliqi merged commit 4037273 into tikv:master Mar 7, 2023
@JaySon-Huang JaySon-Huang mentioned this pull request Mar 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@gengliqi gengliqi gengliqi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guo-shaoge @JaySon-Huang @gengliqi