Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support <engine_role, write> for disaggregated tiflash #6980

Closed
guo-shaoge opened this issue Mar 7, 2023 · 1 comment · Fixed by #6970
Closed

support <engine_role, write> for disaggregated tiflash #6980

guo-shaoge opened this issue Mar 7, 2023 · 1 comment · Fixed by #6970
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@guo-shaoge
Copy link
Contributor

guo-shaoge commented Mar 7, 2023 •
edited
Loading

Enhancement

We want support non-disaggregated tiflash and disaggregated tiflash in one cluster.
So for disaggregated-tiflash, compute node should dispatch MPPTask to tiflash whose label contains <engine, tiflash> and <engine_role, write>.

And for non-disaggregated tiflash, cop task will send to tiflash whose label contains <engine, tiflash> but not contain <engine_role, write>.
@guo-shaoge guo-shaoge added the type/enhancement The issue or PR belongs to an enhancement. label Mar 7, 2023
@guo-shaoge guo-shaoge mentioned this issue Mar 7, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 7, 2023
@guo-shaoge
support <engine_role, write> for disaggregated tiflash (#6970)
79be764 
close #6980
@JaySon-Huang JaySon-Huang mentioned this issue Mar 11, 2023
Closed
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Mar 11, 2023 •
edited
Loading

Changes for TiDB's
tidb-server pingcap/tidb#41978
client-go tikv/client-go#728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support <engine_role, write> for disaggregated tiflash guo-shaoge/tiflash
2 participants
@JaySon-Huang @guo-shaoge