[WIP] Introduce Codec #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
iosmanthus
reviewed
Jul 28, 2022
internal/apicodec/codec.go
Outdated
| // EncodeRange encodes key range. | ||
| EncodeRange(start, end []byte) ([]byte, []byte) | ||
| // DecodeRange decodes key range. | ||
| DecodeRange(encodedStart, encodedEnd []byte) ([]byte, []byte) |
There was a problem hiding this comment.
seem DecodeRange will not be used in the code.
iosmanthus
reviewed
Jul 28, 2022
Comment on lines
+42
to
+48
| EncodeRegionKey(key []byte) []byte | ||
| // DecodeRegionKey decode region's key | ||
| DecodeRegionKey(encodedKey []byte) ([]byte, error) | ||
| // EncodeRegionRange encode region's start and end. | ||
| EncodeRegionRange(start, end []byte) ([]byte, []byte) | ||
| // DecodeRegionRange decode region's start and end. | ||
| DecodeRegionRange(encodedStart, encodedEnd []byte) ([]byte, []byte, error) |
There was a problem hiding this comment.
For PD requests, EncodePDQueryKey and DecodeRegion should be enough.
Signed-off-by: David <[email protected]>
iosmanthus
reviewed
Aug 1, 2022
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
iosmanthus
reviewed
Aug 3, 2022
iosmanthus
reviewed
Aug 3, 2022
iosmanthus
reviewed
Aug 3, 2022
| for _, encodedPair := range encodedPairs { | ||
| var err error | ||
| p := *encodedPair | ||
| if p.Error != nil { |
There was a problem hiding this comment.
Seem this if could be eliminated.
iosmanthus
reviewed
Aug 3, 2022
|
There is a bug that might block this pull request: client-go/txnkv/txnsnapshot/scan.go Line 217 in bb026bd if len(reqEndKey) == 0 || (len(loc.EndKey) > 0 && bytes.Compare(loc.EndKey, reqEndKey) < 0) {
reqEndKey = loc.EndKey
} |
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
ystaticy
reviewed
Aug 8, 2022
| @@ -76,7 +76,9 @@ func (s *apiTestSuite) newRawKVClient(pdCli pd.Client, addrs []string) *rawkv.Cl | |||
|
|
|||
| func (s *apiTestSuite) wrapPDClient(pdCli pd.Client, addrs []string) pd.Client { | |||
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
ystaticy
reviewed
Aug 11, 2022
ystaticy
reviewed
Aug 11, 2022
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Signed-off-by: iosmanthus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims unify
CodecPDClientandCodecPDClientV2by introducing aCodecinterface.