Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore columns that evaluate to NULL #902

Merged
merged 3 commits into from
Jul 17, 2021
Merged

Ignore columns that evaluate to NULL #902

merged 3 commits into from
Jul 17, 2021

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jul 17, 2021

Closes #895. Closes #900.

@krlmlr krlmlr merged commit 03da995 into master Jul 17, 2021
@krlmlr krlmlr deleted the b-895-900-eval-null branch July 17, 2021 16:05
@@ -148,9 +148,7 @@ tibble <- function(...,
.name_repair = c("check_unique", "unique", "universal", "minimal")) {
xs <- quos(...)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is probably better practice for this to also be enquos()?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants