tibble() doesn't always drop NULL columns

[DavisVaughan]

Generally, tibble() drops NULL input columns

library(tibble)

tibble(x = 1:3, y = NULL)
#> # A tibble: 3 x 1
#>       x
#>   <int>
#> 1     1
#> 2     2
#> 3     3

But if the tibble() call is wrapped up in a function, then the internal usage of quo_is_null() doesn't see the input as a NULL value.

library(tibble)

make_tibble <- function(x, y) {
  tibble(x = x, y = y)
}

xx <- make_tibble(1:3, NULL)

xx
#> Error: Internal error in `df_slice()`: Columns must match the data frame size.

str(xx)
#> tibble [3 × 2] (S3: tbl_df/tbl/data.frame)
#>  $ x: int [1:3] 1 2 3
#>  $ y: NULL

I'm fairly certain an easy fix for this is to switch from quos() to enquos() in tibble(), that should be more appropriate anyways as enquos() is for capturing arguments:

tibble/R/tibble.R

Line 149 in 6fb9a90

xs <- quos(...)

And here in tibble_row(), might need to look for more usage of it:

tibble/R/tibble.R

Line 171 in 6fb9a90

xs <- quos(...)

Here is an example of quos vs enquos:

wrap_quos <- function(x, y) {
  rlang::quos(x = x, y = y)
}
wrap_enquos <- function(x, y) {
  rlang::enquos(x = x, y = y)
}

wrap_quos(1:3, NULL)
#> <list_of<quosure>>
#> 
#> $x
#> <quosure>
#> expr: ^x
#> env:  0x7ff0fff0ba70
#> 
#> $y
#> <quosure>
#> expr: ^y
#> env:  0x7ff0fff0ba70

wrap_enquos(1:3, NULL)
#> <list_of<quosure>>
#> 
#> $x
#> <quosure>
#> expr: ^1:3
#> env:  global
#> 
#> $y
#> <quosure>
#> expr: ^NULL
#> env:  empty

[krlmlr]

Thanks, this looks reasonable.

[krlmlr]

Does make_tibble() need to hug its inputs?

---

author: kirill
date: 2021-07-17
output: "reprex::reprex\_document"
title: ok-coqui_reprex.R

library(tibble)

make_tibble <- function(x, y) {
  tibble(x = {{ x }}, y = {{ y }})
}

xx <- make_tibble(1:3, NULL)

xx
#> # A tibble: 3 x 1
#>       x
#>   <int>
#> 1     1
#> 2     2
#> 3     3

str(xx)
#> tibble [3 × 1] (S3: tbl_df/tbl/data.frame)
#>  $ x: int [1:3] 1 2 3

^{Created on 2021-07-17 by the reprex package (v2.0.0)}

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.