Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading RFC 5970 comment in bootfile-url handling #10766

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix misleading RFC 5970 comment in bootfile-url handling #10766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions NetworkPkg/UefiPxeBcDxe/PxeBcDhcp6.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,10 +415,16 @@ PxeBcExtractBootFileUrl (
//

//
// Based upon RFC 5970 and UEFI 2.6, bootfile-url format can be
// tftp://[SERVER_ADDRESS]/BOOTFILE_NAME or tftp://domain_name/BOOTFILE_NAME
// As an example where the BOOTFILE_NAME is the EFI loader and
// SERVER_ADDRESS is the ASCII encoding of an IPV6 address.
// According to RFC 5970, the Boot File URL option does not restrict the
// download protocol, but only requires a valid URL. Although HTTP is
// recommended for network booting, the URL may also follow a TFTP-style
// format. This function expects URLs of the form:
// protocol://[SERVER_ADDRESS]/BOOTFILE_NAME or
// protocol://domain_name/BOOTFILE_NAME
// where SERVER_ADDRESS is an ASCII-encoded IPv6 address and BOOTFILE_NAME
// typically denotes the EFI loader.
//
// Note: Currently, only the TFTP protocol is implemented.
//
PrefixLen = (UINT16)AsciiStrLen (PXEBC_DHCP6_BOOT_FILE_URL_PREFIX);

Expand Down
Loading