Fix misleading RFC 5970 comment in bootfile-url handling #10766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous comment incorrectly suggested that the Boot File URL option in RFC 5970 limits the download protocol. While the RFC allows various protocols, the current implementation only supports TFTP. This patch updates the comment to clarify the current situation. Fixes: tianocore#10742 Signed-off-by: Andreas Florath <[email protected]>
tianocore-assign-reviewers
bot
requested review from
ajfish,
ardbiesheuvel,
leiflindholm,
makubacki,
mdkinney,
SaloniKasbekar and
Zclarkwilliams
SaloniKasbekar
approved these changes
Feb 18, 2025
makubacki
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #10742
This change corrects the misleading comment regarding RFC 5970 in the PxeBcDxe
module.
The previous comment incorrectly suggested that the Boot File URL option in RFC 5970 limits the download protocol. While the RFC allows various protocols, the current implementation only supports TFTP.
This patch updates the comment to clarify the current situation.
No functional code changes were made; this is a documentation fix.
How This Was Tested
The change was reviewed manually to ensure the corrected comment accurately
reflects the intended meaning of RFC 5970.
Integration Instructions
No special integration steps are required, as this is a documentation fix.