Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where drawer icon does not trigger the drawer to open on the feed page #1026

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Jan 8, 2024

Pull Request Description

Review without whitespace

This PR fixes an issue where the drawer icon does not trigger the drawer to open. The solution here was to create a new scaffold key for the main scaffold containing the drawer (thunder_page.dart), and passing that down to the FeedPageAppBar to use.

This also consequently allows me to fix a visual issue where navigating to a community briefly shows the drawer icon rather than the back button. Navigating to communities should now show the proper icon on load!

This is related to #1014.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding and fixing this issue!

This also consequently allows me to fix a visual issue where navigating to a community briefly shows the drawer icon rather than the back button.

Sweet!

@hjiangsu hjiangsu merged commit 5287999 into develop Jan 10, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/drawer-icon branch January 10, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants