Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User navigation fix and error handling #1014

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jan 4, 2024

Pull Request Description

This PR has a couple of fixes for issues related to navigation.

First, I noticed that our regexes for communities were accidentally matching a particular username syntax, like this: /u/[email protected], because we were essentially looking for anything@anything. With this fix, if the community checker parses a name starting with /u/, it will be ignored.

Secondly, I added some error handling around the community navigation page. While we're now less likely to get into this error scenario, it would still be nice to know if the navigation is failing because we are trying to load a community we can't find, so now there is a snackbar indicating when a community load fails.

Review without whitespace.

Issue Being Fixed

Issue Number: Could possibly be related to #1006.

Screenshots / Recordings

This video demonstrates the new error handling prior to fixing the community detection. This would clue us in that we're trying to load this user as a community, and something else is wrong to be investigated!

nav1.mp4

This video demonstrates the correct user navigation after applying the community detection fix.

nav2.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo requested a review from hjiangsu January 8, 2024 03:56
@hjiangsu hjiangsu merged commit 1a5d6ba into thunder-app:develop Jan 8, 2024
1 check passed
@hjiangsu
Copy link
Member

hjiangsu commented Jan 8, 2024

I just noticed one issue with this as I was testing it - the drawer icon no longer opens the feed/subscriptions drawer.

This seems to be related to the Scaffold that was added in feed_page.dart. When tapping on the drawer icon, it attempts to look for the closest Scaffold parent in the widget tree which happens to be the one that was added in. Since that Scaffold does not have a drawer associated with it, it doesn't perform any action!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants