Add support for Redis cluster mode #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaphaelVRossi
suggested changes
Jun 6, 2022
There was a problem hiding this comment.
Hey!
Thank you for contribute!
You can use this PR #9 as tests examples.
After this, for me, it's all good!
|
Hi @RaphaelVRossi 👋🏻 Tests are added in this PR. Waiting for approval from @jaspervanveghel... |
|
Ping @RaphaelVRossi 🏓 |
RaphaelVRossi
suggested changes
Jul 4, 2022
|
@RaphaelVRossi should we wait for one more approval from somebody else to merge this? |
@devppjr Could you please review?! |
|
2.3.0 is live! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hi folks. We were previously maintaining tc-redis-cluster and are in the process of upgrading to Thumbor 7. This PR adds Redis cluster-mode support; which is now also officially supported by redis-py, making this a whole lot easier!