added redis sentinel support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devppjr @masom @phoet @heynemann Hey guys, could you review my changes please? |
RaphaelVRossi
force-pushed
the
add-sentinel-support
branch
5 times, most recently
from
3a439bb to
ccda32f
Compare
devppjr
approved these changes
May 4, 2022
There was a problem hiding this comment.
LGTM ✅ . Could you review too? @masom @heynemann @phoet @Bladrak
Bladrak
requested changes
May 5, 2022
RaphaelVRossi
force-pushed
the
add-sentinel-support
branch
from
ccda32f to
57b2e06
Compare
RaphaelVRossi
force-pushed
the
add-sentinel-support
branch
from
57b2e06 to
f859e51
Compare
Bladrak
approved these changes
May 9, 2022
|
hi @Bladrak @masom, could u publish this version? Or give us permissions to publish, for me and @RaphaelVRossi? Users on pypi:
|
|
@devppjr I've sent invites from pypi, let me know if that works :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to make Thumbor able to connect Redis Sentinel.
To make this possible, we created a
RedisBaseStorageto shared common code betweenStorageandResultStorage, and added a docker with Redis Sentinel to make unit tests possible.