Follow-up: Optimize storage of balance checkpoints in T token contract #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-code detector on maxSupply and delegate is not correct - these functions are used in the inheriting code and may be overwritten. Found and reported two bugs in the detectors in moveVotingPower function. incorrect-equality detector in writeCheckpoint is wrong as well - this line needs to look like that because we want to update the value if we are still in the context of the given block.
We do not need to distinguish self-delegation and delegation to someone else for checkpoint tests. All we care about is that the delegation does not affect the result. Also, the current version covers more paths specific to `getPastTotalSupply`, which is burning from multiple accounts and burning from just one account.
|
Tagging @tomaszslabon as well given that he is working on checkpoints for COV token (coverage pool underwriter token) in keep-network/coverage-pools#199. |
cygnusv
approved these changes
Oct 14, 2021
|
FWIW, I am comfortable with merging with just @cygnusv's approval. I tagged Tomasz so that he is aware of this change but I do not expect him to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #19 and two things are happening here:
mainbuild green again,mint,burn, andburnFromaccording to this comment.I did not look into @vzotova's comment as I was not sure what types the governance contract expects. Leaving it to @cygnusv