-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add governance support for T coverage pool underwriter token holders #199
Conversation
347faa8
to
fa814cb
Compare
fa814cb
to
29980f0
Compare
I think (and please validate it carefully) that all we need is to reduce precision in coverage-pools/contracts/AssetPool.sol Lines 570 to 573 in 3ac3409
|
5961f6e
to
c70b8ce
Compare
c70b8ce
to
fde97c4
Compare
@piotr, if I understand correctly we just need to ensure that the total supply of And this is ensured in the beforeTokenTransfer function, which is called while minting. |
Correct though I think there is an incompatibility of precisions. |
9ca7e29
to
e08955d
Compare
d330ff5
to
10ba5cb
Compare
This PR extends the
UnderwriterToken
by Compound-like voting and delegation features.The following changes were made:
thesis/solidity-contracts
to the newest versionthreshold-network/solidity-contracts
UnderwriterToken
be derived fromCheckpoints
(implemented functionsdelegate()
anddelegateBySig()
)beforeTokenTransfer
so that voting power is given on minting and burning tokens.Checkpoints
can only work with up to2^96 - 1
tokens. To ensure this requirement is handled properly, there is a check that prevents minting moreUnderwriterTokens
than 2^96-1.