Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix test docs #553

Merged
merged 3 commits into from
Jan 25, 2021
Merged

fix test docs #553

merged 3 commits into from
Jan 25, 2021

Conversation

AhmedHanafy725
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 commented Jan 25, 2021 •
edited
Loading

Description

  • Fix repeated test docs
  • cleanup testdocs sal
  • regenerate the docs

Related Issues

#551

Checklist

  • Pre-commit hook is installed to do formatting checks before committing code...etc
  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@AhmedHanafy725 AhmedHanafy725 merged commit 4c8b7d9 into development Jan 25, 2021
@AhmedHanafy725 AhmedHanafy725 deleted the development_fix_testdocs branch January 25, 2021 11:09
sameh-farouk added a commit that referenced this pull request Jan 25, 2021
@sameh-farouk
Merge branch 'development' into this feature branch
421c5f7 
this is necessary to fix repeated test docs #553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abom abom abom approved these changes

@m-motawea m-motawea Awaiting requested review from m-motawea

@rkhamis rkhamis Awaiting requested review from rkhamis

@waleedhammam waleedhammam Awaiting requested review from waleedhammam

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedHanafy725 @abom