Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The tests are repeated when generate tests docs #551

Closed
mhost39 opened this issue Jan 20, 2021 · 4 comments
Closed

The tests are repeated when generate tests docs #551

mhost39 opened this issue Jan 20, 2021 · 4 comments
Assignees
@AhmedHanafy725
Labels
type_bug
Milestone
later

Comments

@mhost39
Copy link
Contributor

mhost39 commented Jan 20, 2021

when using j.sals.testdocs.generate_tests_docs(source='tests/', target='docs/tests') to generate tests docs
found test scenario repeated four and five times
@AhmedHanafy725
Copy link
Contributor

This only happens with parameterized as it repeats the test while loading them

@AhmedHanafy725 AhmedHanafy725 mentioned this issue Jan 24, 2021
Merged
17 tasks
AhmedHanafy725 added a commit that referenced this issue Jan 25, 2021
@AhmedHanafy725
Don't write test docs if it already exists (#551)
1da3157
AhmedHanafy725 added a commit that referenced this issue Jan 25, 2021
@AhmedHanafy725
Cleanup testdocs(#551)
e87f43a
@AhmedHanafy725 AhmedHanafy725 mentioned this issue Jan 25, 2021
Merged
5 tasks
AhmedHanafy725 added a commit that referenced this issue Jan 25, 2021
@AhmedHanafy725
fix test docs (#553)
4c8b7d9 
* Don't write test docs if it already exists (#551)

* Cleanup testdocs(#551)

* Regenerate test docs
@AhmedHanafy725 AhmedHanafy725 mentioned this issue Jan 25, 2021
Merged
5 tasks
@xmonader xmonader added this to the now milestone Jan 25, 2021
@MohamedEssamAdawy
Copy link
Contributor

MohamedEssamAdawy commented Feb 23, 2021 •
edited
Loading

Return to In progress
Tested in development_vdc
commit threefoldtech/js-sdk@d0eea8f

test_vdc_chatflows md (Working Tree) - JS (Workspace) - Visual Studio Code_003

@xmonader
Copy link
Collaborator

if so, let's move it to 2.6

@xmonader xmonader modified the milestones: now, later Feb 23, 2021
@MohamedEssamAdawy
Copy link
Contributor

Verified
The wrong result because I try it in js-sdk and js-ng not released yet.
So the old code used.
After using the write one it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AhmedHanafy725 AhmedHanafy725

Labels
type_bug
Projects
None yet
Milestone
later
Development

No branches or pull requests
4 participants
@xmonader @MohamedEssamAdawy @mhost39 @AhmedHanafy725