Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ldo scenarios #132

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Ldo scenarios #132

wants to merge 16 commits into from

Conversation

jcacosta89
Copy link
Contributor

No description provided.

Remarks:
Maximum upload is 2 Gb
Dem is aggregated to 5x5 results created at 0.5x0.5m
Etc.
Copy link
Contributor

@wvanesse wvanesse Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea was that you would put relevant remarks here, this is just the example I provided, why leave 'etc.'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add a bit more explanation. I think is clearer. Also a bit long but clearer.

Copy link
Collaborator

@wvangerwen wvangerwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added TODO's in the code.
Changed structure a bit and create LDO_API class.

def full_structure(self):
return print(FOLDER_STRUCTURE)

def to_file_dict(self):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I delete lines 116 and 117. With the previous function (lines 98 to 105) is more than enough

@wvangerwen wvangerwen marked this pull request as draft January 20, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants