-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: WebXR examples #218
fix: WebXR examples #218
Conversation
ARButton can specify WebXR session initialization options when the button is clicked. In particular, it offers the ability to define the `domOverlay` property allow DOM elements to render on top of the AR session.
In OculusHandModel and OculusHandPointerModel, the motionController field will be set to an XRHandMeshModel value.
The lightProbe field is a regular Three.js LightProbe object.
The value of "oculus" has not been used for nearly a year. A more generic "mesh" value has been available since r129.
So, I recently got a big change to the @types/webxr package to get them up to date. I've now modified my open PR here to include those types, as suggested in Issue #31. |
@Methuselah96 do you know why the CI is unhappy with this PR? |
@joshuaellis It's due to the change in |
I had committed the modified yarn.lock, but the CI complained about it. So I reverted it and the CI complained again. I just ran |
Why
There are a number of incorrect type definitions in the WebXR examples code. In particular:
ARButton
s optionalsessionInit
constructor parameter is specified asany
XRControllerModelFactory
is missing anenvMap
fieldOculusHandModel
andOculusHandPointerModel
have amotionController
field that is specified asObject3D
, when a more specific type is avaiableXREstimatedLight
'slightProbe
field is specified asunknown
XRHandModelFactory
'screateHandModel
method's optionalprofile
parameter includes"oculus"
as a valid value, when that value has not been available for over a year.What
ARButton
ssessionInit
constructor parameter to an extension of the XRSessionInit that provides for the option of specifying adomOverlay
settingenvMap: Texture
field toXRControllerModelFactory
motionController
field inOculusHandModel
andOculusHandPointerModel
to beXRHandMeshModel
lightProbe
field inXREstimatedLight
's to be Three.js'LightProbe
type.profile
parameter inXRHandModelFactory
'screateHandModel
method's to accept"mesh"
in place of"oculus"
Checklist
master
, next goesdev
)