-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(WebXRManager): add missing methods, update getCamera signature #169
chore(WebXRManager): add missing methods, update getCamera signature #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I needed these types updates too.
Everything sounds good to me.
Btw, with these changes, types better reflects the r140 documentation of WebXRManager.getCamera()
I went ahead and fixed the webxr types and completed three's controller types. Notably, this drops |
@0b5vr if you approve I will merge this. |
#218 merged added |
The changes in my PR were more correct than |
I didn't noticed to this! Let me see this real quick. |
The updated Am I correct in assuming that these types are ambient? I've removed imports to the WebXR definitions accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @CodyJasonBennett see above comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work @CodyJasonBennett & thanks for the reviewing @0b5vr.
Why
Some changes to WebXRManager's signature weren't tracked with mrdoob/three.js#21886 and various other changes with the introduction of layers and controllers.
What
This PR updates the getCamera signature to return an XRCamera and introduces low-level getBaseLayer, getBinding, getFrame, updateCamera, and setReferenceSpace methods. I've vendored Babylon's WebXR types and updated WebXRManager and WebXRController.
Checklist
master
, next goesdev
)