Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/WebGL checks moved to examples/capabilities/WebGL #181

Conversation

schwyzl
Copy link
Contributor

@schwyzl schwyzl commented Feb 22, 2022

The webgl capabilities example has moved to examples/capabilities

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@schwyzl
Copy link
Contributor Author

schwyzl commented Feb 22, 2022

This doesn't work for me, i get the following error:
Property 'isWebGL2Available' does not exist on type 'typeof import("...@types/three/examples/jsm/capabilities/WebGL")'

The export type was changed to 'default' in three, and I don't think I have converted this right to ts.

Any ideas?

@joshuaellis
Copy link
Member

Have you got a link to the source for this? Easier for me to understand whats going on that way.

@schwyzl
Copy link
Contributor Author

schwyzl commented Feb 23, 2022

mrdoob/three.js@ab21bee

@schwyzl
Copy link
Contributor Author

schwyzl commented Feb 23, 2022

The above link is the change to default export type and this is the current source file: https://github.com/mrdoob/three.js/blob/87ab8857957750e5a61dbf0a24b4e8e189efc63f/examples/jsm/capabilities/WebGL.js

@Michsior14
Copy link
Contributor

This is a duplicate of #168

@joshuaellis
Copy link
Member

closing in favour of #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants