Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust webgl example location and types #168

Merged
merged 3 commits into from
Feb 23, 2022
Merged

fix: adjust webgl example location and types #168

merged 3 commits into from
Feb 23, 2022

Conversation

Michsior14
Copy link
Contributor

@Michsior14 Michsior14 commented Jan 28, 2022 •
edited
Loading

Why

WebGL example has changed the placement in the r137. https://github.com/mrdoob/three.js/blob/master/examples/jsm/capabilities/WebGL.js

What

Move the file to the proper path and fix the export according to the code.

Checklist

  • Checked the target branch (current goes master, next goes dev)
  • Added myself to contributors table
  • Ready to be merged

@Michsior14
Copy link
Contributor Author

@joshuaellis, @Methuselah96 Could you please review?

@joshuaellis joshuaellis self-requested a review February 15, 2022 14:17
@joshuaellis
Copy link
Member

Hey @Michsior14, I'll take a look this week. Thank you for the reminder ☺️

@Michsior14
Copy link
Contributor Author

@joshuaellis bump ;)

@Michsior14 Michsior14 mentioned this pull request Feb 23, 2022
Closed
3 tasks
@joshuaellis joshuaellis merged commit 4aa3504 into three-types:master Feb 23, 2022
@joshuaellis
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michsior14 @joshuaellis