fix(WebXRManager): setAnimationLoop should accept null like WebGLRenderer #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaellis
approved these changes
Jan 27, 2022
joshuaellis
added a commit
that referenced
this pull request
Mar 1, 2022
* fix(WebXRManager): setAnimationLoop should accept null like WebGLRenderer (#158) * fix: Missing Property in Raycaster (#160) * Fix Missing Property in Raycaster Adds uv2 to Intersection interface to more accurately reflect the original documentation. See: (https://threejs.org/docs/#api/en/core/Raycaster.intersectObject)[https://threejs.org/docs/#api/en/core/Raycaster.intersectObject] This has been submitted in response to Josh's request in (this PR)[DefinitelyTyped/DefinitelyTyped#58462] * Add name to contributors * r137 (#162) * feat: autodetect sRGB compression * feat: remove inline sRGB decode * chore: remove roughness mipmapper * feat: added constant SRGB8 * feat: WebGLCubeUVMaps: Add support for render targets * chore: Remove RGBFormat (#159) * change: Remove RGBFormat See: mrdoob/three.js#23223 See: mrdoob/three.js#23228 * change: Remove .format from Material See: mrdoob/three.js#23219 It will be replaced with .alphaWrite later See: mrdoob/three.js#23166 * test: remove use of RGBFormat from a test case * feat: add LDrawUtils * chore: make ConvexGeometry points optional * chore: remove RGBIntegerFormat * feat: Box3 now supports computing minimal bounds for setFromObject * feat(Material): Add a new property .alphaWrite (#161) Since it's undocumented I could not fill the doc comment properly,,, See: mrdoob/three.js#23166 * chore: remove UnsignedShort565Type * chore: remove RoomEnvironment from OTHER_FILES * chore: remove LDrawLoader from OTHER_FILES * chore: fix linting * chore: fix linting Co-authored-by: 0b5vr <[email protected]> * feat: add PackedPhongMaterial * fix: Scene Utils are not in namespace resolves #153 * r137 * change (Material): remove `alphaWrite` See: mrdoob/three.js#23361 Co-authored-by: Cody Bennett <[email protected]> Co-authored-by: Joe Tipping <[email protected]> Co-authored-by: Josh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
WebXRManager#setAnimationLoopis called internally byWebGLRenderer#setAnimationLoopto update camera and controller internals with the viewer's pose. Although they are passed the same callback, only WebGLRenderer's signature will accept null for a callback. There, a falsy value will stop the internal animation used to drive the animation loop. WebXRManager will only start/stop when sessions init/end but will respect WebGLRenderer's signature as it is called internally.What
I've updated WebXRManager's signature to match.
Checklist