Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Custom Webpack Configs #16

Merged
merged 4 commits into from
Feb 4, 2022

Conversation

douglas-johnson
Copy link
Member

Related Issues

What Was Accomplished

  • Removed custom webpack configuations from Newsletter and Table of Contents blocks.
    • Those configs existed to prevent the wp-polyfill from being included as a dependency. Now that is the default behavior.
  • Updated the package.json to remove reference to those configurations.
  • Built both blocks using the updated configuration.
    • Only newsletter changed, even then it was only the version number. The distributable block files are identical, there's just fewer config files.

A note on @wordpres/scripts

I had to update my global install of @wordpres/scripts to get this to work. One of their dependencies was having a problem with a failing post-install script.

To get it working, I had to:

  • Update to the latest version of Node through NVM
  • run export NODE_OPTIONS=--openssl-legacy-provider to support Node 17.
  • Install @wordpress/scripts globally with the --ignore-scripts setting

Copy link
Collaborator

@richdacuban richdacuban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@douglas-johnson Looks good to me, after I got npm udated to 17 and wp-scripts updated to latest I was able to build to run the two npm commands to build the newsletter and table of contents blocks.

Checking them out in Cata via Local, the newsletter block needed to be recovered but it was successful. The table of contents block had no recovery needed and was fine.
Screen Shot 2022-02-03 at 4 34 28 PM
Screen Shot 2022-02-03 at 4 46 10 PM
Screen Shot 2022-02-03 at 4 46 27 PM
Screen Shot 2022-02-03 at 4 45 52 PM
Screen Shot 2022-02-03 at 4 47 56 PM
Screen Shot 2022-02-03 at 4 53 08 PM

@douglas-johnson douglas-johnson merged commit 5017622 into main Feb 4, 2022
@douglas-johnson douglas-johnson deleted the issue#15/remove-custom-webpack-configs branch February 4, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove custom webpack configs since wp-polyfill is no longer included by default
2 participants