Introduce a stylesheet_base generator

[mike-burns]

This introduces the suspenders:stylesheet_base generator, which adds
our typical foundations for CSS. In this case it is Bourbon, Neat, and
Refills.

Of note, the application.scss must list the imports in a specific
order.

Paired with Justin Moore.

[houndci-bot]

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

[tute]

This looks very happy to me. ❤️ 🚢

[teoljungberg]

What do you think of keeping the style consistent and re-write this as:

source_root(
  File_expand_path("..", "..", "..", templates),
  File.dirname(__FILE__),
)

[mike-burns]

Everything about this line annoys me. Is there a better way to do this?

[mike-burns]

OK so the status of this seems to be:

• Everyone hates the hideous source_root line.
• Concern over users who have an existing application.css.

@tute @teoljungberg Are these things that should be fixed in this PR?

[tute]

Everyone hates the hideous source_root line.

If we know of a better way we improve it yes, but if not, it shouldn't hold off this PR I think.

Concern over users who have an existing application.css.

Around this your previous last comment said:

Thinking about this more, I'm tempted to issue no warning and not touch anything except app/assets/stylesheets/application.scss.

What do you think -- is that setting someone up for hours of annoying debugging?

I'm ok with that workaround. But there is a bug right now: application.css is not removed any longer:

test1 master % tree app/assets/stylesheets
app/assets/stylesheets
├── application.css
├── application.scss
└── base
    ├── _base.scss
    ├── ...

[teoljungberg]

Everyone hates the hideous source_root line.

If we know of a better way we improve it yes, but if not, it shouldn't hold off this PR I think.

I agree with @tute that that can be left for a future PR.

[mike-burns]

But there is a bug right now: application.css is not removed any longer

Aha! I had missed that. Obvious now. Thanks, fixed.

Now the build is failing because of changes to the gem ecosystem. We should fix master before I merge.

[mcmire]

I just saw this and this seems like a great addition. Thanks @mike-burns.

[rikkipitt]

I haven't had chance to properly delve into this new generator, but are you guys getting the following when bundling? It's because the refills gem is already in the development/test block in the Gemfile while the new generator appends it again to the bottom of the file...

Your Gemfile lists the gem refills (>= 0) more than once.
You should probably keep only one of them.
While it's not a problem now, it could cause errors if you change the version of just one of them later.

[mike-burns]

@rikkipitt I'm not seeing that. Attaching a sample Gemfile that I see. I did this to get it:

mkdir tmp && cd tmp
../suspenders/bin/suspenders sample

Gemfile.txt

[rikkipitt]

@mike-burns Looks like someone else has found this to be the case too in #786